APRProof get_steps optimizations #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetarMax
reviewed
Aug 14, 2024
pyk/src/pyk/kcfg/kcfg.py
Outdated
| # Short-circuit and don't run pathing algorithm if there is no 0 length path on the first step. | ||
| node_1_successors = self.successors(_node_1_id) | ||
| node_2_successors = self.successors(_node_2_id) | ||
| path_lengths = [self.path_length([successor]) for successor in node_1_successors + node_2_successors] |
There was a problem hiding this comment.
I think you could inline the node_1_successors definitions here?
PetarMax
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonzero_depthis (relatively) expensive, when it's done for each pending nodes and we have 50+ pending nodes. This is because it traverses the KCFG to find all paths between the init node and the current node.nonzero_depthtwice unnecessarily. Caches the result in a variable instead.test%kontrol%VetoSignallingTest.testVetoSignallingInvariantsArePreserved4(uint256,uint256,uint256)from the lido tests. Around 400 nodes in, the sync time is 0.3-0.4 seconds without the optimization. With the optimization it is around 0.015 to 0.04 seconds (although this also depends on the number of pending nodes at any given time). This seems to eliminates the bulk of the sync time when there are a large number of pending nodes (~30+).